disable the batch crop button when all images uncroppable #3944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-nowak
force-pushed
the
an/disable-crop-search-page
branch
from
bbf652f to
627d9fb
Compare
|
The styling is a little inconsistent with the download button (in which the style seem a little broken too but I'm not sure that that is related to this change)
There is missing padding to the left of the warning icon / right of the Download label. The warning icon in the crop could use some right padding |
andrew-nowak
force-pushed
the
an/disable-crop-search-page
branch
3 times, most recently
from
74244c4 to
cae03b9
Compare
much easier to follow whats going on this way
andrew-nowak
force-pushed
the
an/disable-crop-search-page
branch
from
cae03b9 to
658dcb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Previously, the "full frame crop" button on the search page was always enabled - even if the image couldn't be cropped! Now the button will be disabled if no images are croppable, or show a warning triangle if some images can't be cropped (like downloads)
How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?